Update reqwest from 0.12 to 0.13, to add support for self-signed certificate stored in an OS's trust store.#67
Open
codercommand wants to merge 4 commits into
Open
Conversation
…ificate stored in an OS's trust store. Signed-off-by: Rian Rutherford <codercommand@gmail.com>
Author
|
Investigating fix for linting error. |
Signed-off-by: Rian Rutherford <codercommand@gmail.com>
mjansson
requested changes
Jul 7, 2026
mjansson
left a comment
mjansson
left a comment
Collaborator
There was a problem hiding this comment.
Since other packages still require reqwest 0.12 we now get dependency on both versions. It also seems 0.12 now gets default features, which pull in a lot of extra dependencies.
I would prefer if you made it work in 0.12 instead until we can shift completely to 0.13 across the board.
Author
|
I can do that. I previously locally had it for 0.12, then thought it'd be helpful to bump it to 0.13 and make PR. Do you want it in this pull request or a new one @mjansson ? |
Collaborator
|
Can do it in this one, will be squashed on intake anyway. |
codercommand
force-pushed
the
fix-reqwest-tls
branch
from
f4b4db2 to
ee42ef4
Compare
Signed-off-by: Rian Rutherford <codercommand@gmail.com>
Author
|
We should be all good now @mjansson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.12 of reqwest doesn't support self-signed certificates that have been added to the OS trust store by default. You must add this feature by adding "rustls-tls-native-roots" flag, or you upgrade to 0.13 which supports self-signed certificates by default. Decided to update to 0.13.
This feature is needed when testing and developing locally with self-signed certificates.